https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #8)
Comment on attachment 117995 [details] [review] Bug 27114: Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab'
Review of attachment 117995 [details] [review]: -----------------------------------------------------------------
This is a breaking change.. I think.. We'll need to advertise that in the release notes to prompt plugin authors to update their plugins.
::: Koha/Template/Plugin/KohaPlugins.pm @@ +166,5 @@
+ try { + my @newtabs = $plugin->intranet_catalog_biblio_tab(); + foreach my $newtab (@newtabs) { + # Add a unique HTML id + my $html_id = 'tab-'. $plugin->{class} . '-' . $newtab->title;
The addition of $plugin->{class} here could cause problems for existing plugins.. we will need to make sure any in the wild are updated.
Why do we add this change exactly? To prevent collision? -- You are receiving this mail because: You are watching all bug changes.