https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #39)
(In reply to Andrew Fuerste-Henry from comment #38)
Searching works for any variant that includes numbers and spaces, but fails once I include the dashes or parens, so the patron doesn't come up when I search for their phone number exactly as it appears in the record.
Hmm good to know. I thought I would've tested that, but the unit test is missing it, so I'll need to update that. Do you have some example phone numbers I could use for testing?
Also, this normalization is not applied to the Standard search when Primary Phone is added to DefaultPatronSearchFields.
Hmm ok I can look that.
Finally, the QA tools are mad about missing POD. [FAIL] Koha/Patrons/DataTables.pm FAIL pod_coverage sub _parse_dbic_query_for_dt has no pod coverage.
This one is driving me crazy. It seems like Tomas arbitrarily started requiring POD for private/internal methods when that's not a thing that's typically done for Perl modules...
https://gitlab.com/koha-community/qa-test-tools/-/work_items/ 103#note_3167812268
I've put the question of POD for private methods on the agenda for tomorrow's dev meeting. In testing this I just used the number from the test plan, '1-(234)-567-8901' -- You are receiving this mail because: You are watching all bug changes.