http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8153 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- I like the idea, however +#if it is bulk receive +if($op eq 'all') +{ +my $sth = $dbh->prepare('select subscriptionid from subscription'); +$sth->execute; +my $row; +while ($row = $sth->fetchrow_array()) { +push (@subscriptionids,$row); +} +}else { +@subscriptionids = $query->param('subscriptionid'); +} in serials-edit.pl has a few problems. 1/ We shouldn't have sql in .pl files 2/ The indentation fails the coding guidelines 3/ This will get all expired subscriptions, ie, it just gets all, that may be thousands for a big library I haven't tested much further. What this patch does, also that is not advertised is it changes the layout of the serials receive page also. -- You are receiving this mail because: You are watching all bug changes.