https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38751 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175702&action=edit Bug 38751: Update ILL::Request->extended_attributes This updates the extended_attributes method to also act as setter. Additionally, it'll skip adding any attribute that result in error, preventing an ugly error 500. Test plan: 1) Enable ILLModule sys pref 2) Attempt to create the following openurl request through the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?DOI=10.1001%2Fjama.2024.11146&atitle=Interventions%20for%20High%20Body%20Mass%20Index%20in%20Children%20and%20Adolescents%3A%20US%20Preventive%20Services%20Task%20Force%20Recommendation%20Statement.&aulast=Nicholson%2C%20Wanda%20K.&backend=FreeForm&cardnumber=53807898&date=20240716&genre=article&id=DOI%3A10.1001%2Fjama.2024.11146&issn=00987484&issue=3&method=create&opac=1&openurl=1 3) Notice it fails with a Duplicate ID error and the OPAC blows up. This is because Koha is trying to add the 'DOI' illrequestattribute twice and that is resulting in a duplicate ID 4) Apply patches, repeat test plan, notice the error no longer happens, the request is created correctly and all successful attribute have been added. -- You are receiving this mail because: You are watching all bug changes.