https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Ok. Rebased, and found a non-minor glitch with `EmbedItems`. I think this is mostly solid, I didn't find broken tests (yet). Tested with the advanced editor (which uses /svc/[new_]bib) I think the patch for `marcrecord2csv` is not correct as we don't have an 'itemnumbers' param being used. I haven't found any use of that method in the code, though. On a follow-up dev, I would make the `EmbedItems` filter just get a `Koha::Items` resultset. I think this patchset is fixing a couple leaks too. If this is not gonna move, I might fix them on a separate bug. -- You are receiving this mail because: You are watching all bug changes.