https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #20)
(In reply to Jonathan Druart from comment #18)
Bug 28306: Trying to understand...
Does this commit title meet our standards? :)
What I would like to understand too, is what happens with Objects.t on this patch. At first glance looks like deleting lots of lines since we cannot resolve a problem with AUTOLOAD or so ?
It was not meant to be pushed. I sent the following email to the QA team on August 31: """ Wanna have some fun? I am struggling with the following situation. Today I pushed bug 28306 and noticed a failure on Objects.t (see from coment 15 - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306#c15) It's absolutely not related with the original patches, but seems to be linked with 17600 (the EXPORT_OK funkiness). So there is an easy fix, two actually: * use C4::Context from the test file (even not used directly from there...) * Use full qualified namespace for dt_from_string That could work, but we don't know what's going on exactly. I've attached a patch to play (comment 18), you just need to run a 3 lines script to recreate the problem A simple call to dt_from_string generates a "The method ->dt_from_string is not covered by tests!" error. Because we are hitting AUTOLOAD (??). But the POD is clear, we shouldn't https://perldoc.perl.org/perlsub#Autoloading And, we are using dt_from_string that way from Koha::Object (singular) and it's working perfectly. So, what's going on? Maybe coming from Koha::DateUtils that is not using EXPORT_OK? I tried, see bug 28931. You can apply the patch from there and try again with the 3 lines script. Unfortunately, it's not fixed, but maybe part of the solution... I need more eyes one this one, please help! """ I didn't receive any feedback and decided to abandon the investigation and push the (meaningless) fix. -- You are receiving this mail because: You are watching all bug changes.