https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #21)
Let's say all our code is messy and so we don't need to tell it every week, deal?
Hehe deal.
We could add a flag to set_rule to not clear the cache, and clear it from set_rules. Would that work for you?
I thought about that but the existing patches are already signed off, so it's probably not a necessary optimization at this point.
In fact, since we're using the L1 cache and the L1 cache is flushed at the end of every HTTP/SIP request, clearing the cache (in ./admin/smart-rules.pl) is actually probably totally unnecessary for production purposes.
Seems a good practices to invalided the cache when the value might have changed. That will prevent bugs in the future.
Agreed. -- Overall, I don't see any blocks/fails for this one. -- You are receiving this mail because: You are watching all bug changes.