http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5549 --- Comment #54 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #53)
Pulled down the new code. Comments as I find them:
high holds has been removed.
I put this on its on bug.
in C4::AddReturn, the call to GetItemIssue no longer passes the $dropbox variable.... since it doesn't seem to do this in master, I think this is yet another additional feature that's been separated out.
Removes bug 6335 content (hadn't noticed that was in there before!)
Reverts the 'use warnings' on many pages.
I put these on bug 2505 where they belong.
Removes passing 'issuescount' to build_issues_data in members/moremember.pl, which is good, since it's redundant to just getting array length.
Leaves release notes and .po files alone.
Remaining issues:
Fixes updatedatabase.pl problems that were noted, however the database update lines added are (mostly) redundant with atomicupdate/issues_datetime.pl Up to the RM on how he wants to handle implementing the database changes here.
rollingloans.t still needs some love.
This either needs sample data added for circ rules and items or to be left out until it does. I don't think it should block this though.
Issues as noted by Hackfesters. Will address in my next comment.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.