https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #7)
(In reply to Jonathan Druart from comment #6)
Hum, I am going to postpone this change for my mental health (holds...)
But at first glance there is something wrong: the diffbranch flag will never be set and we will have a lot of useless code in the template.
Are you sure this change is correct?
I'm not sure what you mean. This doesn't change ModItemTransfer at all. It only replaces a bunch of code with a call to ModItemTransfer *if* the item needs transferred. This reduces code and complexity, and does not affect any other use of ModItemTransfer.
I was not talking about ModItemTransfer. You removed this line: - diffbranch => 1, diffbranch is only sent to the template once, after your patch it will never be set. -- You are receiving this mail because: You are watching all bug changes.