Emmi, can you explain the changes a bit please? Previously copying holidays just simply took holidays from copied branch and inserted them into target branch. This resulted as duplicated values in database. With this patch applied, before inserting holidays, we check which of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475 --- Comment #11 from Emmi Takkinen <emmi.takkinen@outlook.com> --- (In reply to Jonathan Druart from comment #9) them are already present in target calendar. First we get all e.g weekday holidays for both copied branch and target branch. Then, while looping holidays from copied branch, filter out each equally valued keys/values from them with grep and insert rest to target branch. Check for single and exception holidays works just like before and filters all holidays from past (all holidays past todays date).
ie. it hurts my brain to make sure it will not introduce regression, it will help me to PQA if you could show me you know what you are doing :) Uum, I'm not sure if above is what you need but I hope it was explanatory enough. And headache free :D
-- You are receiving this mail because: You are watching all bug changes.