https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- my $items = Koha::Items->search({ biblionumber => $biblionumber }); + + while ( my $item = $items->next ) { + $not_onloan_items++ + if not $item->onloan; + } Can't you combine that in one statement? In general: Do I understand correctly that this is not an optional filter? We will always save the not onloan count to 999$x? Can you also add some explanation on this report why we definitely need it? At this point we are not using it in the codebase. But if we should do after some time, would it feel good to rely on a field in the search engine when we can generate the count in one Koha::Items call ? No blockers, just convince me.. -- You are receiving this mail because: You are watching all bug changes.