http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #16)
Comment on attachment 37583 [details] [review] [SIGNED OFF] Bug 13967 - System preferences need a package
Review of attachment 37583 [details] [review]: -----------------------------------------------------------------
Not worth failing over, but after my testing, this is the only issue I can seem to find.
::: t/db_dependent/sysprefs.t @@ -44,3 @@
);
-$dbh->rollback;
I know it is automatically done when the script closes, but it would be nice to keep it explicit.
At some point it was generally decided to remove the rollback calls. I don't recall when or where. That being said I have no strong opinion on the matter. We can leave that for QA ; ) -- You are receiving this mail because: You are watching all bug changes.