https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25569 Bug ID: 25569 Summary: decreaseLoanHighHolds will decrease loan too often Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The routine checkHighHolds uses CanItemBeReserved to count the number of available items, however, since we must pass the current borrower and check their ability to hold the items, many of the checks in that routine are not necessarily applicable. Additionally the count of holds on the record may be inaccurate: 1 - The borrowers own holds shouldn't be counted - if I am getting several books for a book group or a number of dvds in a set I shouldn't shorten my own loan period 2 - My hold limits may prevent me from placing more holds, but are not relevant in determining if the item is in high demand 3 - My fines may prevent me from placing holds, but shouldn't shorten my loan period 4 - If 6 patrons from another library who can't hold my libraries items have holds on their libraries item, my loan period shouldn't be decreased as they can't get my item anyways 5 - etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.