https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. Atomic update contains SQL error: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'SET @saved_cs_client = @@character_set_client */; 2. There are warnings in the console [Vue warn]: Data property "leftMenu" is already defined in Props. at <Page left-menu=false title="" > at <Main> [Vue warn]: Vue received a Component which was made a reactive object. This can lead to unnecessary performance overhead, and should be avoided by marking the component with `markRaw` or using `shallowRef` instead of `ref` 3. It's missing the "loading" when we fetch data. It's what we do in other places to avoid a "blink" 4. I think the breadcrumb is missing "administration" at the beginning. 5. If you create a new source without patron, you can submit the form (even if marked as required) and you get a 500 ('DBD::mysql::st execute failed: Field 'patron_id' doesn't have a default value') 6. CONSTRAINT `record_source_fk_1` FOREIGN KEY (`patron_id`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE Do we really want the 'on delete cascade' clause here? 7. Found 2 UI bugs but not related to this, reported on bug 34465 and bug 34466. Not blocker of course. 8. Why did you name the directory of the components "record-sources" instead of "RecordSources"? Isn't the standard to have CamelCase for component's names (and this top directory is kind of part of the component name). 9. Cancel link is not a pointer. Cancel link from here <a @click="doCancel($event)" class="router-link-active cancel">{{ $__("Cancel") }}</a> vs Cancel link from AgreementsFormAdd <router-link :to="{ name: 'AgreementsList' }" role="button" class="cancel" >{{ $__("Cancel") }}</router-link > 10. in the routes file title: "List", you are missing $__("") 11. You are not using Breadcrumbs but setTitle in Main, why that? -- You are receiving this mail because: You are watching all bug changes.