http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Now I tested :) 1/ There is no error if the -file parameter is missing. 2/ Explanations are not restored, why don't you store them in the backup file? (explanations are useful when you search a pref without to know its name). 3/ "17 Run with -cmd compare -file zz02 -del. pref zz02 should not be deleted." returns "Adjusted (at most) 2 prefs from this compare." => but no change done. I think you should change in HandleCompareChanges: ++$t && DeleteOnePref($k) if $compare_del; with $t += DeleteOnePref($k) if $compare_del # But need to check "0E0" for 0 Maybe 2 first patches could be squashed. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.