https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39876 --- Comment #19 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #18)
Well then it's wrong. I am sure I fixed that before! It is now with the last patch.
Now 859 after the additional patch. I re-ran everything on the latest main: 1. Run these tests, they should all pass: - prove xt/author/codespell.t - before = 4442 PASS; after = 4441 PASS - prove xt/author/pod_checker.t - before = 3300 PASS; after = 3299 PASS - prove xt/author/podcorrectness.t - before = 3299 PASS; after = 3298 PASS - prove xt/find-missing-csrf.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-filters.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-op-in-forms.t - before = 2 PASS; after = 2 PASS - prove xt/perltidy.t - before = 3020 PASS; after = 3019 PASS - prove xt/pl_valid.t - before = 3300 PASS; after = 3295 PASS - prove xt/single_quotes.t - before = 2 PASS; after = 2 PASS - prove xt/tt_tidy.t - before = 866 PASS; after = 859 PASS [1] 2. Tidy all the files, there should be no changes using a git status: - misc/devel/tidy.pl --perl (before = 3018 files, no changes; after = 3019 files) - misc/devel/tidy.pl --js (before = 282 files, no changes; after = 282 files) - misc/devel/tidy.pl --tt (before = 859 files, no changes; after = 859 files) [2] [3] [1] prove xt/tt_tidy.t - after patch ------------------------------------- prove xt/tt_tidy.t xt/tt_tidy.t .. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. xt/tt_tidy.t .. ok All tests successful. Files=1, Tests=859, 167 wallclock secs ( 0.03 usr 0.01 sys + 1237.54 cusr 390.78 csys = 1628.36 CPU) Result: PASS [2] misc/devel/tidy.pl --tt - before patches -------------------------------------------- Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept [3] misc/devel/tidy.pl --tt - after patches ------------------------------------------- Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept -- You are receiving this mail because: You are watching all bug changes.