https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Kyle M Hall from comment #6)
Would it not be simpler to pass the parameter timeformat => '24hr' to output_pref instead of using an external lib?
I note that output_pref(), if we were to take its name literally, is for formatting date and time *output*. DateTime::Format::MySQL is already used in other places and its name makes it clear that a DateTime passed through is meant to be fed to an SQL query. I think it better that we keep the concerns of formatting timestamps for human display separate from formatting them for computer consumption. I am reseting the status of this bug back to "Passed QA". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.