https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)
1. Can you rename the "$option" parameter to something more meaningful? $option let think it's a hashref.
Done
2. Reading filter_by_user_branch I'd say there is a case where we return undef, and it's not expected (chaining should be allowed). I'd say the 'else' should be removed, to return $self in any cases.
else removed.
3. Actually, maybe you should pass the logged in user instead of the branchcode, that will allow to filter for someone else than the logged in user, and that will make you remove the test on $userenv. What do you think?
I think we need the userenv as we want contextual filtering - i.e. it matters more which branch you are signed in -- You are receiving this mail because: You are watching all bug changes.