https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #7)
Some QA comments: use Modern::Perl
Corrected
Where do you need FindBin for here?
We don't, I've removed it.. I coded it in a hurry whilst I thought of the idea ;)
I understand the test on enable_plugins but I feel that it should be part of GetPlugins somehow. If you did not enable them, GetPlugins should take care of it and return nothing.
Agreed, but I'm not sure of the other implications.. as such I'd prefer to do that in a distinct bug.
The if(@plugins) is not needed. You are looping thru @plugins inside.
Agreed, corrected.
Why do you warn $_ ?
Following prior art. It makes sense to warn like this for such errors. I have however added a Koha::Logger based log line too now so we don't lose warnings for cases where cron sends them to dev/null.
Second patch If you are adjusting the debian koha-conf, you should also touch the other one.
Amended patch. -- You are receiving this mail because: You are watching all bug changes.