https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42766 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202908&action=edit Bug 42766: (QA follow-up) Broaden sensitive patterns We are all lazy, we aren't going to type --password everytime, we should protect 'p' and 'pass' as well This could likely get broader too later TO test: 1 - perl misc/devel/create_superlibrarian.pl --branchcode=CPL --categorycode=S --cardnumber 3 --userid=ted3 --p=dog 2 - Note password is logged 3 - Apply this patch 4 - perl misc/devel/create_superlibrarian.pl --branchcode=CPL --categorycode=S --cardnumber 33 --userid=ted33 --p=dog 5 - Password redacted in log 6 - perl misc/devel/create_superlibrarian.pl --branchcode=CPL --categorycode=S --cardnumber 333 --userid=ted333 --pass=dog 7 - Password still redacted Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.