https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28308 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187992|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192238&action=edit Bug 28308: Remove 0 from "days in advance" for "Advance notice" 0 days in advance means that the notice should not be sent. This patch contains the pl/pm changes: we set to null if 0 is passed, and do not insert a row in borrower_message_transport_preferences Test plan: 0. Do not apply the patches 1. Create some entries with email and days in advance = 0 2. Create some entries with email and days in advance > 0 3. Apply the patches 4. Run the updatedatabase script => The rows in borrower_message_transport_preferences have been removed for days in advance = 0 5. Edit some messaging preferences => 0 has been replace with a blank entry => checkboxes are disabled when blank is selected 6. Save => No new entry in borrower_message_transport_preferences is blank is selected 7. advance_notices.pl still works correctly Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.