https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #98 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #97)
Some more tiny comments from the last big patch:
You say that this (horrible??) category key within the branches hash is not used anymore due to bug 15295 ? I think so too. More evidence to present?
Everywhere it was used, Koha::LibraryCategory is now used
FIXME in transferbook is fine with me. Just leave it. This PE stuff should perhaps be removed, but not on this report.
Definitely not :)
circ/branchtransfers.pl + $item{'tobrname'} = $tobranchcd; and + $item{'tobrname'} = $tobcd; With a corresponding: <td class="tf-destination">[% Branches.GetName( trsfitemloo.tobrname ) %]</td> Do not really look good.. Name versus code?
Yes the var name is wrong. Patch is coming.
L194 Do we still need this warn BTW ?
No idea. In doubt, let's keep it.
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt + <p class="problem">Please return item to: [% Branches.GetName( errmsgloo.msg ) %]</p> Hmm.
Ugly but correct.
I will finish it later next week. I guess that splitting up this patch set in two parts would have been better.
Yes it's what I did for C4::Members. But here for libraries it looked easier to get 1 big test than having to test everything for each patch. -- You are receiving this mail because: You are watching all bug changes.