https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38291 --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- David, I agree with your concerns here, and I think the original patch was wrong to expose this at the catalogue permission level. The endpoint returns the full library group configuration, including the hide_patron_info, limit_item_editing and limit_report_access policy flags, and lets callers filter on them via q. That is access control configuration rather than lookup data. admin/library_groups.pl requires manage_libraries for the same data, so the API should too. I accept that the other catalogue-gated endpoints are better described as technical debt than as precedent, and that the data they expose is much less sensitive than this. I've attached a follow-up that changes GET /library_groups to require parameters => manage_libraries, documents the 403 response, and adds test coverage (a catalogue-only user gets 403, a user with manage_libraries gets 200). I believe this resolves the authorization boundary and information disclosure concern. This endpoint is now the "manage" representation of library groups. I agree with your point that consuming library groups for a specific purpose is a different resource. Rather than loosening permissions here, I'll add purpose-specific endpoints on the bugs that need to consume library groups (for example, the groups available for record source locking on Bug 42625), returning only what that feature needs and without exposing the policy flags or allowing filtering on them. -- You are receiving this mail because: You are watching all bug changes.