https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42152 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #3)
(In reply to Jonathan Druart from comment #1)
1. Apply this patch, time prove xt/author/valid-templates.t => It's faster and we processed the same number of files
Should the number of tests be the same? For me, in main it runs 875 tests. With the patch it runs 863 tests.
I was expecting that, but you are right, they are not. Here is a diff: % diff valid-templates-42152-ok.txt valid-templates-main-ok.txt # What is processed in main and not with the patch: 84a85
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc => My version excluded both doc-head-close, main only excludes the OPAC one
109a111
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/shared.js => Not correct, it's a js file
118a121
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc => Excluded in my version because of the regex '*doc-head-close.inc' in Koha::Devel::Files 252a256,257 /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/0001-Bug-42322-Hide-.patroninfo-and-search-facets-when-co.patch /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/0001-wip.patch => Incorrect, not in the git index
343a349,367
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/erm.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/interlibrary_loans.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/local_use.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/preservation.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref 344a369 /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref => Should not be processed, not inc or tt
514a540
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/how-to.tt => not in git index
726a753
/kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/shared.js => should not be processed, js file
This is now what is processed now that was not before (basically all tt/inc that are outside of opac-tmpl and intranet-tmpl): 849,863d875 < /kohadevbox/koha/misc/cronjobs/rss/lastAcquired-1.0.tt < /kohadevbox/koha/misc/cronjobs/rss/lastAcquired-2.0.tt < /kohadevbox/koha/misc/cronjobs/rss/lastAcquired.tt < /kohadevbox/koha/misc/cronjobs/rss/longestUnseen.tt < /kohadevbox/koha/misc/cronjobs/rss/mostReserved.tt < /kohadevbox/koha/t/db_dependent/misc/translator/tt/en/sample-not-working-2.tt < /kohadevbox/koha/t/db_dependent/misc/translator/tt/en/sample.tt < /kohadevbox/koha/t/lib/plugins/Koha/Plugin/Test/inc/csrf-token.inc < /kohadevbox/koha/t/lib/plugins/Koha/Plugin/Test/inc/test.inc < /kohadevbox/koha/t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt < /kohadevbox/koha/t/mock_templates/intranet-tmpl/prog/en/includes/accounts.inc < /kohadevbox/koha/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt < /kohadevbox/koha/t/mock_templates/intranet-tmpl/prog/fr-CA/includes/accounts.inc < /kohadevbox/koha/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt < /kohadevbox/koha/t/mock_templates/opac-tmpl/bootstrap/en/modules/opac-csp.tt -- You are receiving this mail because: You are watching all bug changes.