https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39224 --- Comment #147 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 202462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202462&action=edit Bug 39224: (QA follow-up) Add Koha::Auth::Client->for_protocol factory Callers dispatching on a provider's protocol column had to hard-code client class names (if/else chains naming Koha::Auth::Client::SAML2 etc). This adds a small factory so new auth mechanisms only need a new entry in the protocol map, and uses it at the exclusive-provider redirect site in C4::Auth. Unknown protocols throw the new Koha::Exceptions::Auth::UnsupportedProtocol exception. Also documents why the exclusive SAML2 redirect is additionally guarded by $shib (is_enabled() validates web-server integration beyond the DB enabled flag). Test plan: 1. prove t/db_dependent/Koha/Auth/Client.t 2. Configure an exclusive SAML2 provider for a hostname and verify the login page still redirects to the IdP Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.