https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #56 from Jonathan Druart <jonathan.druart@gmail.com> --- Late QA review (sorry!) 1. Koha::Item_add_statistic calls C4::Stats 54 sub UpdateStats { 55 my $params = shift; 56 Koha::Statistic->new($params)->store; 57 } Well, then call Koha::Statistic directly and don't rely on C4? :) 2. Does it really make sense to have the new module under Koha::Schema? Especially using the catch-all and ambiguous "Util". Why not Koha::Exception::ExceptionTranslator? or under Koha::Exception::DBIX? 3. Also "Translator" is confusing (it's not about i18n). Suggestions: ExceptionConverter or ExceptionResolver? 4. +This utility is designed to be extended to support: +=item * Multiple database engines (PostgreSQL, SQLite, etc.) Didn't we abandon this idea? -- You are receiving this mail because: You are watching all bug changes.