http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: The patch works great but I have 3 small remarks: 1/ the cat-toolbar include file is included in 2 others tt files (catalogue/labeledMARCdetail.tt and catalogue/imageviewer.tt) 2/ instead of adding a new id "disabled2", it would be better to create a class ? 3/ qa tools complains: * koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: simple-quote string (62) The patch introduces a forbidden pattern: tabulation character (36) The patch introduces a forbidden pattern: simple-quote string (37) The patch introduces a forbidden pattern: simple-quote string (60) The patch introduces a forbidden pattern: simple-quote string (35) The patch introduces a forbidden pattern: simple-quote string (39) Not blocker, it is not introduced with this patch. Marked as Failed QA for 1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.