https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #45)
(In reply to Jonathan Druart from comment #42)
For instance if we are facing perf issues with the fetch of the circ rules, we should then cache them. Other areas would benefit from that kind of change. Code will stay clean and we wouldn't need write acrobatic code in this C4::Circ module, it does not need that :)
I've attached a patch on bug 29623, for discussion.
I tested that similar to here, I did not se any significant performance change. I then tested here without the last two patches to see how much passing rules and dates save us. It turns out it make the routine take longer. I am not sure how/why, but it seems fetching the values was faster than passing them. I obsoleted the last two patches, as those are the ones you didn't like hopefully we can move this forward ;-) -- You are receiving this mail because: You are watching all bug changes.