https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wanted to check the 'size' of this problem a bit more and did some testing. And it's not as bad as one would think: I tested the HTML notices especially and the results are interesting: 1) Slips: use explicit line breaks When a slip template is printed in the browser, only br and other block elements will cause a line break. I fixed some of our sample notices on bug 35187. 2) E-mail notices: use explicit line breaks When an email is sent in HTML format, only br and other block elements will cause a line break. I fixed the WELCOME notice also on bug 35187. 3) Print notices with gather_print_notices and --html: implicit line breaks ------------ Note that we have a known display bug on the notices tab: bug 30287. It shows implicit line breaks, not reflecting how the actual email will look later. ----------- (In reply to Martin Renvoize from comment #24)
OK, I see you're points now.
This was meant to be "least invasive", but I do agree it would be nice to drop it entirely and require proper HTML throughout for these notices.
The challenge will be to write a DB update that looks at all the existing notices and fixes them for all current html notices to include the breaks. We have never used the --html option on this job so I can't tell about how widely it would be used.
I am not sure it's worth messing with the existing notices. * If you have a working email template that is used as a fallback for print, it will definitely add unnecessary/additional line breaks. * So only explicit print layouts that use HTML could be affected negatively. I'd like to avoid a system preference for this inconsistent behavior... but could a command line switch for 'implicit_line_breaks' help some?
Also, we'd need to update all the existing default notices for install.
It's not as big an issue as one would think. I already did it: I fixed all HTML notices in the 3 bugs dependent on this one: 35185, 35186, 35187 With these 3 bugs I believe we can consider the sample notices fixed and improved. It helps that most our notices are still plain text (is_html: 0)
This is all a much larger job that we were expecting to undertake here.. worthwhile I suppose, but I'm not sure where I'm going to find funding for that extra time.
We can have this go in as is, but I believe removing would be better instead of changing the output somewhat arbitrarily. Maybe we should just "bite the bullet" here? -- You are receiving this mail because: You are watching all bug changes.