https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42374 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #13)
Good catch on finding the root cause (autovivication on grep).
Thanks :)
I was focussing on trying to replicate the problem with a simple script to report the issue upstream.
Yeah, it was a complicated one for sure. I've reported it at https://github.com/briandfoy/business-isbn-data/issues/236 and brian d foy has fixed it in version 20260416.001 of Business::ISBN::Data. I've actually been wondering if we need to package Business::ISBN::Data in the Koha Community because I had a Koha library recently not have a 979* ISBN validated because Debian's Business::ISBN::Data was too old. I'll raise a separate issue for that, since it affects a number of things...
I think the change I suggested in comment 2 is a valid fix for Business::ISBN::Data.
You could propose that to brian d foy as well if you like. He addressed the bug a different way, but I think you make a good point there. Maybe add that to the Github issue?
Regarding our temporary fix, shouldn't we instead revert the use Koha::Plugins and replace it with a require?
If that doesn't have any other negative impacts, then I'm all for that - yes. I really don't like that "use Koha::Plugins" as it unnecessarily loads so many modules, which will just slow down the database upgrade. Why don't we do both patches? I'd really like to use your patch, as I think it's the best for Koha overall. Then we can include my patch as a "just in case". And at some point we'll have an upgraded Business::ISBN::Data without the bug as well. Can't go wrong with multiple layers hehe. -- You are receiving this mail because: You are watching all bug changes.