https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Comment on attachment 142701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142701 Bug 32012: runreport.pl should use binmode UTF-8
From ef19187a6588da31d0706e73a6d8f45754b30c30 Mon Sep 17 00:00:00 2001 From: Fridolin Somers <fridolin.somers@biblibre.com> Date: Wed, 26 Oct 2022 23:15:35 -1000 Subject: [PATCH] Bug 32012: runreport.pl should use binmode UTF-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Like Bug 26832 added binmode UTF-8 to script misc/search_tools/export_elasticsearch_mappings.pl, this should be added to misc/cronjobs/runreport.pl.
Test plan : 1) Do not apply patch 2) Create a SQL report with : S SELECT 'accentué',barcode FROM items limit 3 3) Note the id of this report, for example 1 4) Run : misc/cronjobs/runreport.pl 1 --format csv | tee /tmp/without.csv => You see output with unknown char instead of é : accentu<?>,1 accentu<?>,2 accentu<?>,3 5) Run : file --mime-type /tmp/without.csv => You see : /tmp/without.csv: iso-8859-1 6) Apply patch 7) Run : misc/cronjobs/runreport.pl 1 --format csv | tee /tmp/with.csv => You see correct output : accentué,1 accentué,2 accentué,3 8) Run : file --mime-type /tmp/without.csv => You see : /tmp/without.csv: utf-8 --- misc/cronjobs/runreport.pl | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/misc/cronjobs/runreport.pl b/misc/cronjobs/runreport.pl index d6fbb7fcbc..8b3c12b3b0 100755 --- a/misc/cronjobs/runreport.pl +++ b/misc/cronjobs/runreport.pl @@ -164,6 +164,8 @@ Reports - Guided Reports
=cut
+binmode STDOUT, ":encoding(UTF-8)"; + # These variables can be set by command line options, # initially set to default values.
-- 2.35.5
-- You are receiving this mail because: You are watching all bug changes.