https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #2)
The code puts '' if there is no location key. But if the location key is NULL, because I hadn't set my shelving location, there is NULL. Do we want NULL's? If so, I'll sign this off. If not, could you tweak that?
I think we should always use NULL is the location is not passed or is set to undef. It seems like odd behavior to convert undef values to empty strings. -- You are receiving this mail because: You are watching all bug changes.