https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26820 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Summary|"Important" flag enforced |"Important" and "Mandatory" |only at subfield level |flags enforced only at | |subfield level for tags < | |010 in basic editor --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Yeah, it's https://git.koha-community.org/Koha-community/Koha/src/commit/1ea4a11c2a88f7... which has been like that since the migration to Template Toolkit in 2011. I don't know where to look for history before that, but I'd be equally unsurprised if before there was another loop that handled 000-009 which had the separate message "Tag 001 is mandatory, it must be filled in" which didn't get migrated, or, that it has always been that way. The way that now the advanced editor enforces field-level mandatory/important on < 010 and the basic editor does not makes the excuse that "it would be confusing to have a message '... at least one of its subfields must be filled' for a field with only one subfield" seem less confusing than just ignoring the field flag in one of the two editors is. For a no-new-strings patch to backport, just removing the if(parseInt(arr[0])
= 10) condition would work fine. Or for new strings, removing the condition and looking at the field number in the for( var prop in mandatoryFields ) loop below to decide between the "at least one of its subfields must be filled" or a new "it must be filled" string would be prettier.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.