http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Paul, this is a bug fix, rather than a feature. This patch is to correct a problem that exists in Koha, where using IndependantBranches can result in items not being returnable to a library, even when they should be. This is a problem with returning items, rather than transferring them. Kyle (In reply to comment #19)
Can't this feature be achieved already with branch transfer limits ? I thought that, with this feature activated, one can do much precise return rules than with just a syspref.
Looking at the code, I realize I'm wrong: C4/Circulation.pm, sub AddReturn says:
if ($hbr ne $branch && C4::Context->preference("IndependantBranches") && !(C4::Context->preference("canreservefromotherbranches"))){ $messages->{'Wrongbranch'} = { Wrongbranch => $branch, Rightbranch => $hbr, }; $doreturn = 0; # bailing out here - in this case, current desired behavior # is to act as if no return ever happened at all. # FIXME - even in an indy branches situation, there should # still be an option for the library to accept the item # and transfer it to its owning library. return ( $doreturn, $messages, $issue, $borrower );
But shouldn't we use the branch_transfer_limit anyway (and not this new syspref)
(just throwing asking the question, not rejecting the patch)
-- You are receiving this mail because: You are watching all bug changes.