https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152923|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153225&action=edit Bug 34182: Don't set biblio.serial based on biblio.seriestitle in AddBiblio A misunderstanding of the intention of some dead code that probably wanted to set biblio.series (which doesn't exist) left us setting biblio.serial if biblio.seriestitle was set. The only thing series and serial have in common is the first four letters. We shouldn't set serial on something with a series (unless someone also sets serial on it, of course). Test plan: 1. Administration - MARC bibliographic framework - Actions button next to Default framework - MARC structure 2. In the Search for tag input type 942 and click search 3. Actions button next to 942 - Edit subfields 4. Tab s - check the checkbox for Editor, uncheck the checkbox for Collapsed - Save changes 5. Cataloging - New record 6. Click in the input for 000 and hold down Tab until you get past 008 to fill in mandatory default values, then type any character in 040 subfield c 7. Tab 2 - In 245 subfield a type Series not serial 8. Tab 4 - In 490 subfield a type any character 9. Tab 9 - Set the value of subfield c to Books 10. Click save and leave the tab open to keep the biblionumber 11. Cataloging - New record - repeat step 6 12. Tab 2 - In 245 subfield a type Serial not series 13. Tab 9 - Set the value of subfield c to Books - Type 1 in subfield s 14. Click save, the biblionumber should be one higher than the first one 15. Reports - Create from SQL 16. Type something in Report name, paste in the SQL SELECT biblio.serial, biblio.seriestitle, biblio.title FROM biblio WHERE biblionumber IN ("","") and put your first biblionumber in the first "", your second in the second. 17. Save report - Run report 18. Series not serial should have a blank in the serial column and the character you typed in the seriestitle column; Serial not series should have a 1 in the serial column and a blank in the seriestitle column. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.