https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #36 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Emily Lamancusa (emlam) from comment #32)
This generally looks good!
Just one other thing - when an order is placed from a suggestion, the suggestion is automatically marked as ORDERED and the patron is notified. The same behavior should occur when a suggestion is linked to an order after the fact, otherwise it will be confusing for staff and likely lead to customers missing notifications.
I went ahead and attached a follow-up patch for this, since it was trivial to do while I had the existing code up anyway to check for any other inconsistent behaviors. Aleisha, can you take a look at the last patch and let me know if you agree with it? If so, I'm ready to mark this PQA
Sorry it took a while for me to revisit this, Emily! Happy with your final two patches. Please PQA when you're ready. -- You are receiving this mail because: You are watching all bug changes.