http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #93 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #82)
From code review:
1) (normal) The descriptions for edit_items_restricted and items_bachmod_restricted are now no longer correct, since the preferences have been added to avoid hardcoding MARC fields - maybe refer to the prefs instead?
Done.
2) (non blocker) Patch keeps(?) a CGI::scrolling_list instance - could be in conflict with one of Bernardo's patches there: additem.pl: $subfield_data{marc_value} =CGI::scrolling_list(@scrparam);
Yes, it will be in conflict, but seems quite easy to fix.
3) (non blocker) Database updates could be merged.
Done.
3) Suggestion: should we squash the patches (maybe 1-9 + )? Because the permissions got renamed and some other things that could avoid some confusion.
I squashed DB patches. I would like to keep the history (especially because I'm not the author of the first patch).
Also an updated summary of the changes and a test plan would be great.
I forgot that... -- You are receiving this mail because: You are watching all bug changes.