https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #25)
We don't use --preload-app, so we don't need to worry about it. I know that. Quoting etc.
Even if we did use --preload-app, I think some of the text is misleading. While code changes to code that is preloaded wouldn't come through, changes to code that is lazy loaded after forking the children would still come through. This explains my testing. Lazy brain :) All workers need to cache the old code first obviously. I just got the wrong worker a few times. Inspired by Victor, I will set the number of workers as low as possible and test again..
I chose the about.pl test somewhat arbitrarily because koha-testing-docker is such a small database. In production, where you really see this being useful is in search.pl and opac-search.pl where a search might take 5+ seconds. Using koha-plack --reload will wait for that long search request to complete, and then it will restart that worker. I do not use k-t-d, but your point is clear.
Resuming QA scheduled for this afternoon. -- You are receiving this mail because: You are watching all bug changes.