https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37472 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #7)
Thanks for taking a look!
I assume that the idea is to not copy the template files to a de-DE directory, but handle all the translations on the fly. Is this correct?
The translated template files are copied into a de-DE directory in the plugin directory rather than being added to all the existing core translated files. This is so that if a plugin is ever uninstalled it removes the translated files and they're not hanging around with the core templates. We use the de-DE directory that now sits in the plugin to substitute the translated templates, the same way as we do in core Koha
I think it makes sense to store the translations within the plugin, but I assumed we'd use the "on the fly technique" that would not require creating a translated version of the template files. This might give an idea of what I mean: https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_con... Or here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
In that case I am not sure why an install translation step for plugins would be needed, as I assume they would come with all available languages po files as part of their source. What is achieved by installing a language for a plugin?
The plugins contain the po files but not the translated templates. The install step is needed to translate these using the core translation code, rather than needing to write translation code into the plugins themselves. It also takes any javascript strings and adds them to the existing javascript translations. (The plugin actually handles the translation step itself, see below)
See above - I think we could avoid creating the templates and saving us some steps in doing so. I was hesitant to use the method on "all of Koha" back then, mostly for concerns about performance and readability... but maybe plugins are the perfect use case here. I assume that the .po/.mo files we'd be dealing with would be quite small. -- You are receiving this mail because: You are watching all bug changes.