http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #91 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #88) Thanks for your quick response and changes.
At this moment in the process, it is not clear what is used (probably only email) and what is not. That makes a push not very obvious?
I tried to explain the complete feature in a previous email to koha-devel: all patches should be reviewed together and pushed together, in order to keep thing consistent (for the review, not the same day :)) Sorry, I have seen your email passing by, but it got lost :) Imo it would be easier to have all information on the report. (Perhaps a document attachment explaining some thing or so..)
* Functionality: I can imagine that I have filled in multiple transport types but want to activate or deactivate some of them. Would you need some status on each of them? I am sorry but I don't understand what you mean here. Now you see the 4 or 5 types (and that could grow..?) But I miss a field like Status that activates or deactivates the transport type for that notice. We could also use that status somehow to warn people that activating a certain type is not useful or even possible when there is no code to support it yet.
* Functionality clash? For Overdue notice (phone notice): I can select all transport types. Confusing.. I don't find this notice in sql files. Normally, with this feature, all notices created for a specific transport type, should be moved "into" the "main" notice. For instance, "Overdue notice (phone notice)" should be moved into the "phone" template for the "Overdue" notice. Yes, that sounds more logical to me. This notice must have come from some earlier test perhaps..
* From commit: [Currently, only email, sms and print are relevant.] Note that you could hide what is not relevant now? Maybe someone else would like to implement phone, etc. So I did not restrict the mtts to display on the interface. OK Same comment as above actually: What about not allowing to enable the types that are not yet supported?
I do not change the status for now. Appreciate feedback on the questions raised. -- You are receiving this mail because: You are watching all bug changes.