https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. tests are missing 2. 739 return [] if ( C4::Context->preference('marcflavour') ne 'MARC21' ); Why that? Where is it advertised? 3. 781 my $marc; 782 eval { $marc = $self->metadata->record; }; 783 return unless $marc; I disagree with that, and I thought we agreed on it. We must assume the MARC is good, and deal with invalid record on the detail page (and edition now) only. The comment is also wrong, you could call this method from somewhere else, and we just ignore the error, which we should (almost) never do. 4. Finally, isn't this change enough? -my $show_volumes = @{ $biblio->get_marc_volumes(1) } ? 1 : 0; +my $show_volumes = ( !$invalid_marc_record && @{ $biblio->get_marc_volumes(1) } ) ? 1 : 0; -- You are receiving this mail because: You are watching all bug changes.