https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208936&action=edit Bug 16763: Remove the use of "onclick" from record matching rules form This patch revises the record matching rules edit form to remove the use of "onclick" in favor of defining events in JavaScript. The in-page JS has been moved to a separate file. Also changed: Custom form validation JS is replaced by use of the built-in validation plugin. To test, apply the patch and go to Administration -> Record matching rules. - When adding or editing a record matching rule, the description, match threshold, and record type should be required. - Entries in the following fields should be validated to require that only digits be entered: Match threshold, Score, Offset, and Length - With both match points and match checks, the "add" and "remove" links should work correctly to show a new section with a blank form. "Add" and "remove" links should work correctly whether the form is in a saved state (i.e. the saved data has just been opened for editing), or whether the links have been added to the page as part of an "add" operation. - When adding a match point or a match check, data added in additional entries should be saved correctly. - After removing a match point or match check, the data should be saved correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.