https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36026 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #24)
(In reply to Marcel de Rooy from comment #23)
(In reply to Katrin Fischer from comment #22)
This looks like a communication problem to me at this point and I try to resolve. Re-reading your comment doesn't give me any new clue. Could you try to re-phrase?
We are not testing the actual code in the test plan. We are testing the optional flag which is actually not safe. The test plan should focus on testing the proposed changes, fully using TLS.
Code looks good to me btw.
So the issue with the test plan might be due to problems in making things work with koha-testing-docker. :( We have been testing this patch on a package installation both at KIT and BSZ for a while now.
Could the other concern be moved to a separate bug since this patch didn't introduce the flag?
If this is thoroughly tested, I would recommend to record that on the commit message and remove/edit the current test plan which makes not much sense. Put some sign-off lines on it that really count. -- You are receiving this mail because: You are watching all bug changes.