https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Ere Maijala from comment #65)
Caching in GetMarcFromKohaField is indeed useless, I'll remove it. Also the test missing is something I need to fix. I can also make the missing itype check use Koha::Item->effective_itemtype to avoid duplication since it shouldn't be a common situation. What I don't really like is to use a known slow method for fetching the data from the database. I can change it to use Koha::Items->search since the changes still help improve the performance, but I'm not convinced that's the way it should be.
If you are calling Koha::Items->find( $item->{itemnumber} )->effective_itemtype, my guess is that the Koha::Items->search will not have a big impact. -- You are receiving this mail because: You are watching all bug changes.