https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38253 --- Comment #29 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #28)
(In reply to Tomás Cohen Arazi (tcohen) from comment #27)
(In reply to Johanna Räisä from comment #26)
Created attachment 179380 [details] [review] [review] [review] Bug 38253: (follow-up) add boolean value to body parameter
This patch adds the boolean value to the body parameter to change the status of the lowest priority hold.
It looks better, but what would be the semantics for `false` being passed? It looks like the code still sets the lowest priority?
It should restore the priority I'd say.
Sent before finishing my reply.
I think you are right but at the moment the function which is handling this in pl-file is like this. =head2 ToggleLowestPriority ToggleLowestPriority( $borrowernumber, $biblionumber ); This function sets the lowestPriority field to true if is false, and false if it is true. =cut sub ToggleLowestPriority { my ($reserve_id) = @_; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare("UPDATE reserves SET lowestPriority = NOT lowestPriority WHERE reserve_id = ?"); $sth->execute($reserve_id); _FixPriority( { reserve_id => $reserve_id, rank => '999999' } ); } When the toggle is made it will always set rank as 9999. Not sure why it is made like that, maybe that part should be fixed? -- You are receiving this mail because: You are watching all bug changes.