https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #29 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Nick Clemens from comment #27)
I worry about this line: return { status => 'OK' } if ( $canReserve->{status} eq 'notReservable' && $opacitemholds eq 'N' ); as it short circuits some other checks, but I think the scripts end up double checking and it is not a problem. Other that that all the login in the scripts should be in the modules ;-)
Checks not made in ILS-DI, at least when I first looked at the bug ;) Moving checks in this modules will helps maintaining coherence between interfaces (so i think...) but any opinion is welcome :) @Katrin : I see that there is now a "params" which might help passing data to these function, i'll try to get previous behaviour using this argument. -- You are receiving this mail because: You are watching all bug changes.