https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38414 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 188040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188040&action=edit Bug 38414: Check for permissions in reports preview sql modal This bug refactors the preview sql modal so that it is mostly rendered by the template without js. That allows us to check for the appropriate permissions before adding the buttons to the modal. To test: 1. Create some reports 2. Create a user with only execute_reports permissions 3. Login as that user and go to Reports > use saved 4. In the actions column click the ^ and select 'Preview sql' 5. Notice delete button renders and works to delete 6. Apply patch and restart_all 7. Repeat step 4, now only the Run report button renders and works 8. Add permissions for create_reports 9. Repeat step for, now Edit, Duplicate, Schedule and run buttons render and work 10. Add permissions for delete_reports 11. Repeat step 4, confirm the delete button renders and works 12. Confirm the preview sql button works to preview different reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.