https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82977|0 |1 is obsolete| | --- Comment #155 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83983&action=edit Bug 18736: (QA follow-up) Change to signed, add large int test [1] Add trivial subtest in t/Number/Price.t Checking a negative number and a large number for the MAX_INT change. Note: Confusing to have t/Prices.t too. [2] Change UNSIGNED to SIGNED in get_rounding_sql. Although I did not spot problems with negative prices, we theoretically could while casting. cast(-2 as unsigned) == 18446744073709551614 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.