https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 Bug ID: 27769 Summary: Advanced editor shouldn't break copying selected text with Ctrl+C Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl, nick@bywatersolutions.com Depends on: 17179 Bug 17179 added a shortcut for Ctrl+C to copy the line where the cursor is into the advanced editor's clipboard div. That only works if you don't have text selected. If you have text selected, the shortcut silently does nothing, but Ctrl+C, which I've used for decades to copy selected text, doesn't copy the text. Dozens of times a day, I copy the OCLC control number from a record, or the contents of an 024, do an advanced search for that number (where I can no longer actually see what record I'm replacing), and replace the record. Despite having now spent months trying to train myself that Ctrl+C has been broken (difficult training since I catalog both on a Mac, where Cmd+C has not been broken, and on Windows where it has), every couple of weeks I catch myself having just replaced a record with some record I had previously successfully right-click copied data from. How often do I *not* catch myself, and replace a record with a record for a completely different bib? Dunno, I'd really rather not think about that. The keyhandler looks like it'a a CodeMirror command, and the very scanty documentation says that a CodeMirror key handling command can return CodeMirror.Pass to let other handlers or the default behavior handle the key. Currently the handler does "return true" when it sees selected text and decides not to handle Ctrl+C. If instead returning cm.Pass would make the system clipboard work when text is selected, and the advanced editor clipboard work when no text is selected, that would be the best outcome. Second best would be deciding that silently causing the system clipboard to fail was a bad idea, and switching the default shortcut to something else. Yes, there is a system-wide option to change keys. For me, that means getting 14 people to agree on a different key, then starting the process of persuading an admin to make the change. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.