14 Nov
2014
14 Nov
'14
10:32 a.m.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Frédéric Demians from comment #6)
I don't understand, what is "the first place"?
I mean: Is it really necessary to use timezone in dt_from_string function?
I don't know.
Otherwise, I fully agree that your patch solve the bug (ugly one). I would add a FIXME comment in the code to point to bug number, in order to avoid that someone else reintroduce the bug in the future.
Maybe a test based on localtime_before - localtime_after should be < 3 sec. But it's not really clean, it could depend on the load of the machine. -- You are receiving this mail because: You are watching all bug changes.